-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance API Security #1430
Open
mshakirdfe
wants to merge
9
commits into
staging
Choose a base branch
from
feature/188885-API-security-enhancement
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enhance API Security #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are too many files for me to review and I am not an expert in .NET so I am removing myself as a reviewer |
ConcernsCaseWork/ConcernsCaseWork.API.Tests/Fixtures/ApiTestFixture.cs
Outdated
Show resolved
Hide resolved
ConcernsCaseWork/ConcernsCaseWork.API/Features/ConcernsStatus/ConcernsStatusController.cs
Outdated
Show resolved
Hide resolved
ConcernsCaseWork/ConcernsCaseWork.Data/Migrations/20241203102737_ChangedTTEOptionName.cs
Show resolved
Hide resolved
mshakirdfe
force-pushed
the
feature/188885-API-security-enhancement
branch
from
January 2, 2025 09:28
05cd01a
to
a89d6cb
Compare
mshakirdfe
force-pushed
the
feature/188885-API-security-enhancement
branch
from
January 6, 2025 12:04
f8f84ea
to
743668e
Compare
…hub.com/DFE-Digital/record-concerns-support-trusts into feature/188885-API-security-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Token based Authentication and Role Based Authorisation
Why do we need the change?
Improve security posture
What is the impact?
Azure DevOps Ticket
https://dev.azure.com/dfe-gov-uk/Academies-and-Free-Schools-SIP/_workitems/edit/186437
https://dev.azure.com/dfe-gov-uk/Academies-and-Free-Schools-SIP/_workitems/edit/188885